[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 05:05:08 PDT 2017


yaxunl added a comment.

In https://reviews.llvm.org/D36259#830122, @bader wrote:

> Out of curiosity: how did you detect this?
>  Can we use the same approach for writing tests?


Some user code generated call to a select function which we do not have in library, then Brian found that there are extra select function in opencl-c.h.

I guess that's just good luck. We still do not have a systematic approach to test opencl-c.h.


https://reviews.llvm.org/D36259





More information about the cfe-commits mailing list