[PATCH] D36261: [clangd] Use multiple working threads in clangd.

[Manuel Klimek via Phabricator via cfe-commits]

klimek added inline comments.


================
Comment at: clangd/ClangdServer.h:105
+/// A helper class to pass concurrency parameters to ClangdScheduler.
+class SchedulingParams {
+public:
----------------
I think calling it "Options" is more idiomatic.


================
Comment at: clangd/ClangdServer.h:110
+  static SchedulingParams RunOnCallingThread();
+  /// Indicates then requests should be executed on separate worker threads. In
+  /// total \p ThreadsCount working threads will be created.
----------------
Typo: Indicates *that*.


================
Comment at: clangd/ClangdServer.h:121-122
+public:
+  /// Returns the number of threads to use when shouldRunsynchronously() is
+  /// false. Must not be called if shouldRunsynchronously() is true.
+  unsigned getThreadsCount();
----------------
Why not: 1 -> run synchronously, > 1, run in parallel?


https://reviews.llvm.org/D36261