[PATCH] D34512: Add preliminary Cross Translation Unit support library

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

Organizationally, this seems fine. Carry on :)



================
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229-231
+def err_fnmap_parsing : Error<
+  "error parsing CrossTU index file: '%0' line: %1 'USR filename' format "
+  "expected">;
----------------
Please add a new `DiagnosticCrossTUKinds.td` file for the new subdirectory.


================
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:13-14
+//===----------------------------------------------------------------------===//
+#ifndef LLVM_CLANG_TOOLING_CROSSTRANSLATIONUNIT_H
+#define LLVM_CLANG_TOOLING_CROSSTRANSLATIONUNIT_H
+
----------------
This should be updated to match the new directory.


================
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:30
+
+namespace crossTU {
+
----------------
This doesn't follow either of our normal conventions for namespace names within Clang and LLVM (`CamelCase` and `snake_case`, with the latter being more common). Maybe `cross_tu`?


https://reviews.llvm.org/D34512