[PATCH] D33676: Place implictly declared functions at block scope

Momchil Velikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 2 08:15:20 PDT 2017


chill added inline comments.


================
Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522
   // to be re-used for method bodies as well.
-  ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope);
+  ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope|
+                           Scope::CompoundStmtScope);
   Actions.ActOnStartOfFunctionDef(getCurScope(), LM.D);
----------------
aaron.ballman wrote:
> Did clang-format produce this? The lack of spaces between the `|` operators is surprising. Same comment applies elsewhere, so you might want to run clang-format over the patch if you've not already done so.
No, I wrote it manually like this to match the already existing style. Will be glad to run clang-format on all the touched files, though.


https://reviews.llvm.org/D33676





More information about the cfe-commits mailing list