[PATCH] D36142: clang-format: [JS] do not insert whitespace in call positions.

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 1 09:04:51 PDT 2017


djasper added inline comments.


================
Comment at: lib/Format/TokenAnnotator.cpp:2355
+        (Left.Tok.getIdentifierInfo() ||
+         Left.isOneOf(tok::kw_switch, tok::kw_case, tok::kw_delete)))
+      return false;
----------------
Why is instanceof not required in this list?


================
Comment at: unittests/Format/FormatTestJS.cpp:237
+  verifyFormat("x.switch() = 1;");
+  verifyFormat("x.case() = 1;");
   verifyFormat("x = {\n"
----------------
no test for delete?


https://reviews.llvm.org/D36142





More information about the cfe-commits mailing list