[PATCH] D36149: [Tooling] Add LLVM_NODISCARD to Replacements::merge

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 1 07:16:15 PDT 2017


krasimir created this revision.
Herald added a subscriber: klimek.

This patch adds LLVM_NODISCARD to Replacements::merge. I've hit this
several times already.


https://reviews.llvm.org/D36149

Files:
  include/clang/Tooling/Core/Replacement.h


Index: include/clang/Tooling/Core/Replacement.h
===================================================================
--- include/clang/Tooling/Core/Replacement.h
+++ include/clang/Tooling/Core/Replacement.h
@@ -255,7 +255,7 @@
 
   /// \brief Merges \p Replaces into the current replacements. \p Replaces
   /// refers to code after applying the current replacements.
-  Replacements merge(const Replacements &Replaces) const;
+  LLVM_NODISCARD Replacements merge(const Replacements &Replaces) const;
 
   // Returns the affected ranges in the changed code.
   std::vector<Range> getAffectedRanges() const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36149.109108.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170801/d14043e0/attachment.bin>


More information about the cfe-commits mailing list