[PATCH] D35012: [refactor] Add the AST source selection component
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 1 03:16:01 PDT 2017
klimek added a comment.
Apart from nits, looks OK to me - Eric, are all your concerns addressed?
================
Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:51-53
+ ast_type_traits::DynTypedNode Node;
+ SourceSelectionKind SelectionKind;
+ std::vector<SelectedASTNode> Children;
----------------
As this is a public interface, perhaps we should make them const?
Repository:
rL LLVM
https://reviews.llvm.org/D35012
More information about the cfe-commits
mailing list