[PATCH] D35449: [X86] Implement __builtin_cpu_is

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In https://reviews.llvm.org/D35449#826381, @craig.topper wrote:

> @erichkeane are you ok with this code for now? I think validateCPUIs gives you what you need at least for Sema support for target attribute. You'll probably need to refactor the CG code to make your ifunc resolver. But I think you need to do that for the existing feature code that's similar anyway. And from our side conversation it sounds like you're not ready for that yet.


Thats correct.  I think this is right based on what I currently understand, though you/I will likely need to make some additional modifications to support my features.


https://reviews.llvm.org/D35449