r309504 - CodeGenModule.cpp: [PR33810][Modules] Remove an assertion that confirms MangledDeclNames[CanonicalGD] might be still empty.

NAKAMURA Takumi via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 29 23:39:52 PDT 2017


Author: chapuni
Date: Sat Jul 29 23:39:52 2017
New Revision: 309504

URL: http://llvm.org/viewvc/llvm-project?rev=309504&view=rev
Log:
CodeGenModule.cpp: [PR33810][Modules] Remove an assertion that confirms MangledDeclNames[CanonicalGD] might be still empty.

FIXME: It is accepted that MangledDeclNames[CanonicalGD] is overwritten here?

Modified:
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp

Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=309504&r1=309503&r2=309504&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Sat Jul 29 23:39:52 2017
@@ -745,8 +745,6 @@ StringRef CodeGenModule::getMangledName(
 
   // Keep the first result in the case of a mangling collision.
   auto Result = Manglings.insert(std::make_pair(Str, GD));
-  assert(MangledDeclNames.find(CanonicalGD) == MangledDeclNames.end() &&
-         "CanonicalGD is already mangled.");
   return MangledDeclNames[CanonicalGD] = Result.first->first();
 }
 




More information about the cfe-commits mailing list