[PATCH] D35925: [Coverage] Precise region termination with deferred regions

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

This is awesome!

I noticed in the sample output that llvm-cov is now forced to print some new region markers because the terminator introduces a new region on the same line, e.g.

  |// CHECK-LABEL: _Z10while_loopv:
     88|      1|void while_loop() {
     89|      1|  if (false)
     90|      1|    return; // CHECK: [[@LINE]]:11 -> [[@LINE+2]]:3 = (#0 - #1)
                    ^0    ^1  // Previously, llvm-cov didn't show region markers for this line
     91|      1|

Do you think this can be avoided? Should llvm-cov even try to avoid emitting the region markers? It seems to me that this situation affects just the command-line output of llvm-cov, and region highlighting in HTML won't be impacted by this.


https://reviews.llvm.org/D35925