[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

Stephen Hines via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 12:09:39 PDT 2017


srhines added a comment.

This looks better. It did lose context however, so some of the review is harder to read.



================
Comment at: test/CodeGenCXX/warn-padded-packed.cpp:84
+
+struct S16 { // expected-warning {{padding size of 'S16' with 2 bytes to alignment boundar}} expected-warning {{packed attribute is unnecessary for 'S16'}}
+  char a,b;
----------------
boundar -> boundary ?


================
Comment at: test/CodeGenCXX/warn-padded-packed.cpp:93
+
+struct S18 { // expected-warning {{padding size of 'S18' with 2 bytes to alignment boundar}} expected-warning {{packed attribute is unnecessary for 'S18'}}
+  struct S16 s;
----------------
boundary?


https://reviews.llvm.org/D34114





More information about the cfe-commits mailing list