[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

Dehao Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 08:30:39 PDT 2017


danielcdh marked an inline comment as done.
danielcdh added a comment.

Thanks for the review!

In https://reviews.llvm.org/D35746#822498, @chandlerc wrote:

> LGTM with a tiny tweak below.
>
> Would be good to add a test that this flag is being honored, either in this patch or in a follow-up.


I'll add the test in a follow-up patch. Could you help suggest how to add a test for this? Shall I just invoke "clang -cc1 -fexperimental-new-pass-manager" and check if discriminator is generated? That seems an integration test.


https://reviews.llvm.org/D35746





More information about the cfe-commits mailing list