[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 11:51:09 PDT 2017


yaxunl added a comment.

In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:

> Can we drop the "opencl" part of the name and use something like __scoped_atomic_*?   Also, it may not make sense to support non-constant scope here since we can't predict what other scopes may be added by other languages in the future.


we could use the approach of LangAS, i.e. we allow targets to map all language specific scopes to target-specific scope names, since IR only cares about scope names, which are target specific. And this is what the current implementation does.

I have no objection to use the __scoped_atomic_ name. It is more general and extensible. John/Anastasia, any comments? Thanks.


https://reviews.llvm.org/D28691





More information about the cfe-commits mailing list