[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 10:05:08 PDT 2017


dcoughlin added a comment.

Do we have a radar for this? It sounds familiar.



================
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313
 
+static bool isNoReturnBlock(const CFGBlock *Blk) {
+  if (Blk->hasNoReturnElement())
----------------
Maybe a better name for this would be "treatAsSink"? This way people won't use it as short-hand for whether the block has a no-return element.


Repository:
  rL LLVM

https://reviews.llvm.org/D35674





More information about the cfe-commits mailing list