[PATCH] D35796: [analyzer] Misused polymorphic object checker

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 05:41:28 PDT 2017


NoQ added a comment.

It seems that this check is more powerful because it works by knowing the dynamic type of the object. However, i still suspect that `-Wnon-virtual-dtor` (the other one, without `delete-`, that simply asks to make the destructor of polymorphic classes virtual) covers most practical cases. The only thing i see not covered by `-Wnon-virtual-dtor` but covered by this checker is the situation when the destructor is private. Reka, would you confirm our understanding?


https://reviews.llvm.org/D35796





More information about the cfe-commits mailing list