[PATCH] D35673: [analyzer] A better CFG-based suppress-on-sink.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 01:27:38 PDT 2017


a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.

Just a minor nit.



================
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3332
+
+    if (Visited.count(Blk)) {
+      // We've encountered a loop. We won't see anything new here anymore.
----------------
The check for visited can be placed into the loop below so we won't even add such blocks to the worklist.


https://reviews.llvm.org/D35673





More information about the cfe-commits mailing list