[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 15:30:22 PDT 2017


erichkeane added a comment.

In https://reviews.llvm.org/D35701#816721, @krytarowski wrote:

> In https://reviews.llvm.org/D35701#816703, @erichkeane wrote:
>
> > In https://reviews.llvm.org/D35701#816680, @krytarowski wrote:
> >
> > > Bitrig has to be eliminated - it's dead upstream and will be removed from LLVM. (confirmed from ex developers, nobody needs it any more)
> >
> >
> > I just did a bit of looking about, and noticed that the "Bitrig" token is in a bunch of places.  I suspect what we need is for a single pair of patches (llvm & clang) dedicated to removing it.  I'd prefer to do those in a dedicated patchset if thats OK.
>
>
> Please go for it.
>
> Bitrig code has been merged back to OpenBSD.


Ok, great!  I'm working on a series of patches to delete it right now on top of this patch.  I'll make sure to add you to the review.


https://reviews.llvm.org/D35701





More information about the cfe-commits mailing list