[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D24892#733016, @alexfh wrote:

> In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D24892#732217, @alexfh wrote:
> >
> > > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote:
> > >
> > > > Is there any way for multiple checks to share an option?
> > >
> > >
> > > There's OptionsView::getLocalOrGlobal. See how StrictMode option is read in ArgumentCommentCheck, for example.
> >
> >
> > ArgumentCommentCheck uses getLocalOrGlobal, but InefficientStringConcatenationCheck and SuspiciousEnumUsageCheck don't.
> >  6 checks have an IncludeStyle option that isn't shared.
> >  4 checks share a HeaderFileExtensions option, but with different defaults.
>
>
> The right thing would be to fix these. I might get around to this, if nobody does this before me.


Better late than never: r308605 ;)

Any specific plans re: this patch?


https://reviews.llvm.org/D24892