[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:1910
+    const Decl *D, llvm::GlobalValue *GV, CodeGen::CodeGenModule &CGM,
+    ForDefinition_t IsForDefinition) const {
   if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D)) {
----------------
To preserve existing behavior, please make all of the existing implementations you've modified just do an early return if !IsForDefinition.

In the MIPS implementation, you can just handle the long-call attributes first and then exit, unless you feel up to auditing the rest of the attributes there to see if they belong on declarations.


Repository:
  rL LLVM

https://reviews.llvm.org/D35479