[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

Roland McGrath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 14:31:30 PDT 2017


mcgrathr requested changes to this revision.
mcgrathr added a comment.
This revision now requires changes to proceed.

Looks almost right.  Might be overkill to add a test case that -z rodynamic is omitted with -fuse-ld=gold or something.



================
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:51
 
+  CmdArgs.push_back("-z");
+  CmdArgs.push_back("rodynamic");
----------------
Should be inside the lld conditional, since only lld groks -z rodynamic.


Repository:
  rL LLVM

https://reviews.llvm.org/D35582





More information about the cfe-commits mailing list