[PATCH] D35012: [refactor] Add the AST source selection component
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 18 01:39:06 PDT 2017
klimek added inline comments.
================
Comment at: lib/Tooling/Refactoring/ASTSelection.cpp:100
+ SelectionStack.back().Children.push_back(std::move(Node));
+ return true;
+ }
----------------
arphaman wrote:
> klimek wrote:
> > Why do we always stop traversal?
> False stops traversal, true is the default return value.
Ah, right. Generally, I'd have expected us to stop traversal once we're past the range?
Repository:
rL LLVM
https://reviews.llvm.org/D35012
More information about the cfe-commits
mailing list