[PATCH] D35483: clang-format: fix block OpeningLineIndex around preprocessor

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 13:06:21 PDT 2017


krasimir added a comment.

Nice!



================
Comment at: lib/Format/UnwrappedLineParser.cpp:461
+
+size_t UnwrappedLineParser::computePPHash() const {
+  size_t h = 0;
----------------
@djasper: do you aware of some baked-in hash-combine functionality in llvm which this can use directly? If there is no, I'm happy with this.


================
Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:556
+}
+
 TEST_F(NamespaceEndCommentsFixerTest,
----------------
Maybe also add some negative tests?


https://reviews.llvm.org/D35483





More information about the cfe-commits mailing list