[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

Chih-Hung Hsieh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 11:09:22 PDT 2017


chh added a comment.

If most code can be shared in a common base class like CloexecCheck,
maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs
to consolidate all review efforts.
I also prefer a separate check name for each function,
so users can enable/disable each check.


https://reviews.llvm.org/D35372





More information about the cfe-commits mailing list