[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

I'd have a look soon.

Is diff 1 the original diff from https://reviews.llvm.org/D28953? It was ok to reopen it, but the new revision is also fine.

Regarding 1-bit bools: did you notice https://reviews.llvm.org/D32328 and https://reviews.llvm.org/D35041, do they accidentally help?



================
Comment at: include/clang/AST/Expr.h:3096
+  static bool isCommutativeOp(Opcode Opc) {
+    return Opc == BO_Mul || Opc == BO_Add || (Opc >= BO_EQ && Opc == BO_Or);
+  }
----------------
There seems to be a typo somewhere around the last comparison.


https://reviews.llvm.org/D35450