[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 16 20:05:26 PDT 2017


dexonsmith added a comment.

In https://reviews.llvm.org/D35159#809724, @erik.pilkington wrote:

> Rebase. I don't think the issue of purging underscores from this file/libcxx should block this, if we want to discuss that cfe-dev would probably be the place. I agree that it would be nice to clang-format this file, would anyone have any problems with me committing that after this? I found the git-blame of this file to be pretty useless, almost every line just points to r184097. 
>  Are there any other thoughts on this change?


I suppose you may as well pick a new name for "string_ref" that doesn't have underscores, since it's a new type, if someone is going to follow up to drop underscores.  Perhaps "StringView"?


https://reviews.llvm.org/D35159





More information about the cfe-commits mailing list