[PATCH] D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>

[Rui Ueyama via Phabricator via cfe-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: clang/lib/Driver/Driver.cpp:1283
+      for (StringRef S : DiagnosticIDs::getDiagnosticFlags())
+        if (StringRef(S).startswith(PassedFlags))
+          SuggestedCompletions.push_back(S);
----------------
nit: StringRef(S) -> S as S is already a StringRef.


https://reviews.llvm.org/D35447