[PATCH] D34440: [Clang] Expand response files before loading compilation database

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In https://reviews.llvm.org/D34440#809522, @klimek wrote:

> In https://reviews.llvm.org/D34440#809325, @vladimir.plyashkun wrote:
>
> > Even if i'll change content of //arguments.rsp// to
> >  `-std=c++11 -Ipath/to/include -Ipath/to/include2 -DMACRO ....`
> >  and will try to call clang-tidy process in this way:
> >  `clang-tidy -checks=* main.cpp -export-fixes=... -- @arguments.rsp`
> >  it also has no effect, because all compiler options will be ignored (i thinks it's because that //stripPositionalArgs()// function deletes @arguments.rsp parameter as unused input).
>
>
> Ah, ok: this is definitely the way it should work (adding the response file after the --). I think this is the use case we should fix - probably by fixing stripPositionalArgs?


At which point is `stripPositionalArgs` called? Also (in case we want to actually support this use case) should we only allow response files when using the fixed compilation database or for any compilation database (I highly doubt about the latter)?


Repository:
  rL LLVM

https://reviews.llvm.org/D34440