[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 13 13:41:19 PDT 2017


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/android/CloexecEpollCreate1Check.cpp:21
+
+static constexpr const char *EPOLL_CLOEXEC = "EPOLL_CLOEXEC";
+
----------------
Please make this declaration consent across all checks. In some checks it declared inside namespaces, in some - outside.


================
Comment at: docs/ReleaseNotes.rst:60
 
+- New `android-cloexec-epoll-create1
+  <http://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-epoll-create1.html>`_ check
----------------
Please sort checks in alphabetical order.


Repository:
  rL LLVM

https://reviews.llvm.org/D35365





More information about the cfe-commits mailing list