[PATCH] D33644: Add default values for function parameter chunks

[Manuel Klimek via Phabricator via cfe-commits]

klimek added a reviewer: rsmith.
klimek added a comment.

+Richard, as apparently we get the source ranges for default values of built-in types without the preceding "=", but for user-defined types including the preceding "=" - is that intentional?



================
Comment at: lib/Sema/SemaCodeComplete.cpp:2424
+    // If we don't have '=' in front of value.
+    // Lexer returns built-in types values without '=' and user-defined types values with it.
+    return " = " + DefValue;
----------------
"The Lexer returns default-values of built-in types without '=', and default-value of user-defined types with it."

But apart from that: that seems like a bug in the range of the default value? I'm now really confused :)


https://reviews.llvm.org/D33644