[PATCH] D35230: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo

Chih-Hung Hsieh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 11 09:21:50 PDT 2017


chh added inline comments.


================
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
-      } else {
-        FixItInsertionLine.clear();
-        break;
       }
----------------
alexfh wrote:
> Did you figure out why the old code used to give up here? Why does your code just continue?
I don't know. It does not make sense to me for the use cases I think should work.
Hints can contain suggested changes for different files and lines.
If those hints can be in any order, resetting FixItInsertLine and break from the loop would lose the collected line.



https://reviews.llvm.org/D35230





More information about the cfe-commits mailing list