[PATCH] D35225: [clang-tidy] add regression test to performance-unnecessary-value-param

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:1
-// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t
+// RUN: cp %S/Inputs/performance-unnecessary-value-param/header.h %T/header.h
+// RUN: cp %S/Inputs/performance-unnecessary-value-param/header-fixed.h %T/header-fixed.h
----------------
I'd leave this test alone and add a separate one to test the fix in the header.


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:2
+// RUN: cp %S/Inputs/performance-unnecessary-value-param/header.h %T/header.h
+// RUN: cp %S/Inputs/performance-unnecessary-value-param/header-fixed.h %T/header-fixed.h
+// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- -- -std=c++11 -I %T
----------------
No need to copy this file, the test doesn't change it.


https://reviews.llvm.org/D35225