[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

This looks great, thank you very much.



================
Comment at: test/Analysis/plist-macros.cpp:2
 // RUN: %clang_analyze_cc1 -analyzer-checker=core,unix -analyzer-eagerly-assume -verify %s
-// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix -analyzer-eagerly-assume -analyzer-output=plist-multi-file -analyzer-config path-diagnostics-alternate=ture %s -o %t.plist
 // RUN: FileCheck --input-file=%t.plist %s
----------------
ddcc wrote:
> NoQ wrote:
> > > `path-diagnostics-alternate=ture`
> > 
> > Ouch. Thanks for fixing this.
> > 
> > Maybe it'd be great to implement an option that enables validating analyzer config option values, and turn this option on in `%clang_analyze_cc1`.
> I agree that'd be useful, but I think that it should be a separate future patch.
Sure sure.


https://reviews.llvm.org/D28953