[PATCH] D35186: [analyzer] Add annotation for functions taking user-facing strings

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 18:24:58 PDT 2017


dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

Thanks for the patch! This looks very good to me.

The one thing I would suggest is renaming 'isAnnotatedAsLocalized()' and 'isAnnotatedTakingLocalized()' to make it more clear what each does, now that there are two of them. How about: 'isAnnotatedAsReturningLocalized()' and 'isAnnotatedAsTakingLocalized()'?


https://reviews.llvm.org/D35186





More information about the cfe-commits mailing list