[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 9 06:14:57 PDT 2017


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

@dexonsmith I'm not sure it's sane to allow reentrant behavior. Could you explain why you think it is? Should the copy assignment operator allow reentrancy as well?

However there is another bug here. `operator=(function&&)` doesn't correctly call the destructor of the functor. I'll fix that as a separate commit.


https://reviews.llvm.org/D34331





More information about the cfe-commits mailing list