[PATCH] D33719: Add _Float16 as a C/C++ source language type

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 7 01:47:33 PDT 2017


SjoerdMeijer added a comment.

Thanks Richard. I've opened an cxx abi issue, see comments inline. I will start working now on the doc update, and will do that in a companion change. Cheers.



================
Comment at: lib/AST/ItaniumMangle.cpp:2457-2460
+  case BuiltinType::Float16:
   case BuiltinType::Half:
     Out << "Dh";
     break;
----------------
rsmith wrote:
> Distinct types should have distinct manglings. Please open an issue at https://github.com/itanium-cxx-abi/cxx-abi/ to discuss how to mangle these cases.
I've opened issue:
https://github.com/itanium-cxx-abi/cxx-abi/issues/21


https://reviews.llvm.org/D33719





More information about the cfe-commits mailing list