[PATCH] D35108: Fix crash parsing invalid code
Roger Ferrer Ibanez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 7 00:56:29 PDT 2017
rogfer01 added a comment.
Hi @ogoffart thanks for fixing this.
I suggest some minor change for the check, other than that this looks good to me.
================
Comment at: lib/Sema/SemaChecking.cpp:12099
BaseType = BaseType->getPointeeType();
RecordDecl *RD = BaseType->getAs<RecordType>()->getDecl();
----------------
Can you make the check for `RD->isInvalidDecl()` here instead?
```
if (RD->isInvalidDecl())
return;
```
https://reviews.llvm.org/D35108
More information about the cfe-commits
mailing list