[PATCH] D35078: [clang-tidy] Fix modernize-use-override incorrect replacement
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 6 14:27:43 PDT 2017
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a nit.
Thank you for the fix!
================
Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:43
while (!RawLexer.LexFromRawLexer(Tok)) {
- if (Tok.is(tok::semi) || Tok.is(tok::l_brace))
+ if ((Tok.is(tok::semi) || Tok.is(tok::l_brace)) && !Parens)
break;
----------------
s/!Parens/Parens == 0/
Maybe also change Parens to NestedParens or NestingLevel.
Repository:
rL LLVM
https://reviews.llvm.org/D35078
More information about the cfe-commits
mailing list