[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea added a comment.

In https://reviews.llvm.org/D29905#800416, @Hahnfeld wrote:

> In https://reviews.llvm.org/D34888#799576, @gtbercea wrote:
>
> > Does this also include the fixes in the following revision?
> >
> > https://reviews.llvm.org/D29905
>
>
> Sorry, I wasn't aware of this revision and thought that it had long been committed. I just verified that the bug referenced in the summary is also fixed by my patch in https://reviews.llvm.org/D34888. However, I can't comment on whether this patch is still needed. Sorry for the conflicts if yes...
>
> You probably should commit your patches earlier, you currently have 10 accepted revisions that have not yet been committed. This will also avoid complicated rebases and so on.


No problem at all! I am trying to commit the rest of the patches. Currently waiting on one more patch to get approved that will unlock the rest. I do encourage you to review/comment on it: https://reviews.llvm.org/D34784 :)


Repository:
  rL LLVM

https://reviews.llvm.org/D29905