[PATCH] D34512: Add preliminary Cross Translation Unit support library

[Manuel Klimek via Phabricator via cfe-commits]

klimek added a comment.

In https://reviews.llvm.org/D34512#800626, @whisperity wrote:

> In https://reviews.llvm.org/D34512#800502, @xazax.hun wrote:
>
> > In https://reviews.llvm.org/D34512#800499, @klimek wrote:
> >
> > > In https://reviews.llvm.org/D34512#800490, @xazax.hun wrote:
> > >
> > > > It looks like Richard approved libTooling as a dependency for clang on the mailing list (http://lists.llvm.org/pipermail/cfe-dev/2017-July/054536.html).
> > > >  If it is ok to have this code in libTooling (for now), I think we could start/continue the review of this patch.
> > >
> > >
> > > I read that somewhat differently? It seems like Richard basically proposes adding a new library for things that control how we run clang in a multi-TU scenario. I'd call it libIndex, but that already exists :)
> >
> >
> > No, but since Richard said he did not see any justifications to include this in libTooling, I had the impression this is not his final word, and in case you see it justified, this remains the suggested direction. 
> >  But in this case I will rewrite this patch to create a new library. Are you still interested in reviewing it? Do you have any other name in mind? What about libCrossTU?
>
>
>
>
> In https://reviews.llvm.org/D34512#800625, @xazax.hun wrote:
>
> > In https://reviews.llvm.org/D34512#800618, @klimek wrote:
> >
> > > +Richard as top-level code owner for new libs.
> > >
> > > For bikeshedding the name: I'd have liked libIndex, but that's already taken. CrossTU doesn't seem too bad to me, too, though.
> >
> >
> > Some brainstorming for the bikeshedding: libProjet, libProjectIndex, libImport
> >  The reason I am not sure about the Index in the name because this code does not contain (yet) an interface to create/handle indexes. 
> >  The import might be a good once, since this library is basically wrapping the ASTImporter to import code from external sources, but it might be misleading, since ASTImporter is in the AST module.
>
>
> Cross-TU is now used (in the lifeline of these features introduced by the team) in multiple contexts: CTU analysis, and now CTU lookup.
>  Maybe the name of this lib should reflect on the fact that the lib is used to support **cross-TU definition lookup**.
>
> Hmm... `libCrossTULocator`?


Well, a better name for locator is index :)


https://reviews.llvm.org/D34512