[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 6 03:14:17 PDT 2017


xazax.hun added a comment.

In https://reviews.llvm.org/D34512#800499, @klimek wrote:

> In https://reviews.llvm.org/D34512#800490, @xazax.hun wrote:
>
> > It looks like Richard approved libTooling as a dependency for clang on the mailing list (http://lists.llvm.org/pipermail/cfe-dev/2017-July/054536.html).
> >  If it is ok to have this code in libTooling (for now), I think we could start/continue the review of this patch.
>
>
> I read that somewhat differently? It seems like Richard basically proposes adding a new library for things that control how we run clang in a multi-TU scenario. I'd call it libIndex, but that already exists :)


No, but since Richard said he did not see any justifications to include this in libTooling, I had the impression this is not his final word, and in case you see it justified, this remains the suggested direction. 
But in this case I will rewrite this patch to create a new library. Are you still interested in reviewing it? Do you have any other name in mind? What about libCrossTU?


https://reviews.llvm.org/D34512





More information about the cfe-commits mailing list