[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>
Melanie Blower via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 5 13:48:14 PDT 2017
mibintc updated this revision to Diff 105329.
mibintc added a comment.
I responded to the review from Jonas Hahnfeld: I moved the entire change into ToolChains/Linux and removed the modifications to Gnu.h and Gnu.cpp; I modified the new tests to use -### with FileCheck, and added a tree in Inputs/ for the new tests. Jonas please see inline reply concerning whether to--or how to--check for existence of stdc-predef.h
Also, note that there are some tests from clang-tidy that need to be updated. I have a separate patch for that since it's in a different repo. I assume it would be good to get those modifications landed before this patch.
https://reviews.llvm.org/D34158
Files:
lib/Driver/ToolChains/Linux.cpp
lib/Driver/ToolChains/Linux.h
test/Driver/Inputs/stdc-predef/bin/.keep
test/Driver/Inputs/stdc-predef/usr/i386-unknown-linux/lib/.keep
test/Driver/Inputs/stdc-predef/usr/include/stdc-predef.h
test/Driver/Inputs/stdc-predef/usr/lib/.keep
test/Driver/Inputs/stdc-predef/usr/x86_64-unknown-linux/lib/.keep
test/Driver/clang_cpp.c
test/Driver/crash-report.c
test/Driver/gcc-predef-not.c
test/Driver/gcc-predef.c
test/Index/IBOutletCollection.m
test/Index/annotate-macro-args.m
test/Index/annotate-tokens-pp.c
test/Index/annotate-tokens.c
test/Index/c-index-getCursor-test.m
test/Index/get-cursor-macro-args.m
test/Index/get-cursor.cpp
unittests/Tooling/TestVisitor.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34158.105329.patch
Type: text/x-patch
Size: 23154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170705/314c99e7/attachment-0001.bin>
More information about the cfe-commits
mailing list