[PATCH] D34947: [clangd] Add support for per-file extra flags

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

I forgot to submit this last comment yesterday, sorry about that.



================
Comment at: clangd/GlobalCompilationDatabase.h:51
 
+  void addExtraFlagsForFile(PathRef File, std::vector<std::string> ExtraFlags);
+
----------------
Maybe rename to `setExtraFlagsForFile`?
The name `addExtraFlags...` sounds like it appends to the existing list, but we actually replace the flags there.


https://reviews.llvm.org/D34947