[PATCH] D34955: [Basic] Detect Git submodule version in CMake

Jordan Rose via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 3 09:20:52 PDT 2017


jordan_rose requested changes to this revision.
jordan_rose added a comment.
This revision now requires changes to proceed.

If I'm remembering correctly from when I set this up, this isn't just about detecting which version control system you're using; it's about finding a file //that will change on every commit.// Otherwise, the generated Version.cpp won't be rebuilt after you update.

If you don't want to go looking for a better choice for this that would handle submodules, a stopgap answer would be to add a second entry that just looks for `.git` in addition to the one looking for `HEAD`.


https://reviews.llvm.org/D34955





More information about the cfe-commits mailing list