[PATCH] D34364: [analyzer] Faster hashing of subsequences in CompoundStmts.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 2 00:57:32 PDT 2017


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

This looks negligible compared to compilation time.
I wonder if we're now scalable enough to try finding whole-translation-unit clones.



================
Comment at: lib/Analysis/CloneDetection.cpp:402
   auto CS = dyn_cast<CompoundStmt>(S);
   SmallVector<size_t, 8> ChildHashes;
 
----------------
Hmm, is 8 enough here? People often write large functions. Maybe bump to 32 or 64?


https://reviews.llvm.org/D34364





More information about the cfe-commits mailing list