[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409
+            << (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange()
+                                       : FD->getSourceRange());
+    } else 
----------------
Underlining the entire function is probably not useful; I would just use `FD->getExceptionSpecSourceRange()` here -- that way you just won't get any highlighting if there isn't an explicit exception spec.


Repository:
  rL LLVM

https://reviews.llvm.org/D34671