[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Sema/SemaDecl.cpp:13693-13694
+              // passes the structural compatibility check in C11 6.2.7/1.
+              bool AllowODR = getLangOpts().CPlusPlus || getLangOpts().ObjC1 ||
+                              getLangOpts().C11;
               NamedDecl *Hidden = nullptr;
----------------
I don't think this should require C11 -- in C89 the corresponding rule is in 6.1.2.6/1, so the rule exists in all languages that Clang supports.


https://reviews.llvm.org/D31778