[PATCH] D34329: [clang-diff] Initial implementation.

Raphael Isemann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 04:33:24 PDT 2017


teemperor added a comment.

I didn't have time to have a close look at this patch, but it seems you're interested in the specific TU-independent data of a Stmt to compare them. So if you are interested in the such data and don't want to write your own function to collect data it for each Stmt subclass, there is the `StmtDataCollector` in the CloneDetection.cpp here <https://clang.llvm.org/doxygen/CloneDetection_8cpp_source.html#l00139> and a example how to use it is here <https://clang.llvm.org/doxygen/CloneDetection_8cpp_source.html#l00482>.

I'm fine with moving this into a header and make it more usable for this use case if you think it makes sense to use it here. The main advantage would be that we don't get yet another of these classes in clang (we already have 3 of them: One in the Stmt profiler code, another one in the ODRHash code for modules and another one in the CloneDetection code).


https://reviews.llvm.org/D34329





More information about the cfe-commits mailing list