[PATCH] D34871: [OpenCL] Add function name to extension diagnostic
Alexey Bader via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 30 02:48:05 PDT 2017
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Just one minor comment.
Thanks.
================
Comment at: clang/Sema/Sema.h:8435
/// \return true if type is disabled.
- bool checkOpenCLDisabledDecl(const Decl &D, const Expr &E);
+ bool checkOpenCLDisabledDecl(const FunctionDecl &D, const Expr &E);
----------------
I think it's better to use NamedDecl to allow this function be used for declarations other than FunctionDecl.
https://reviews.llvm.org/D34871
More information about the cfe-commits
mailing list