[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

Richard Trieu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 29 15:06:23 PDT 2017


rtrieu added a comment.

Reid is correct, the whitelisted expressions was greatly reduced during code review so only casts to void would disable the warning.  While the last review did not have the description updated to reflect this, the committed code does have an accurate description.  What is the reason to exclude void expressions now?  For the function case, it is more consistent to warn on all function calls since we can't determine if a function returns void just by looking at the call site.


Repository:
  rL LLVM

https://reviews.llvm.org/D34810





More information about the cfe-commits mailing list