[PATCH] D34725: Add sample PGO integration test to cover profile annotation and inlining.

[David Li via Phabricator via cfe-commits]

davidxl added inline comments.


================
Comment at: test/CodeGen/pgo-sample.c:4
+// Ensure Pass SampleProfileLoader is invoked.
+// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -mllvm -debug-pass=Structure -mllvm -inline-threshold=0 -emit-llvm -o - 2>&1 | FileCheck %s
 // CHECK: Remove unused exception handling info
----------------
using a a negative threshold to make sure regular inline heuristic does not kick in?

Also how about new PM?


================
Comment at: test/CodeGen/pgo-sample.c:28
+// of foo:bar.
+// CHECK-NOT: call void @callee
+void foo(int x) {
----------------
SHould this be 'CHECK-NOT:  call'  as bar is also inlined?


https://reviews.llvm.org/D34725